Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable native-tls in favour of rustls #4

Merged
merged 1 commit into from
May 11, 2022
Merged

Disable native-tls in favour of rustls #4

merged 1 commit into from
May 11, 2022

Conversation

indiv0
Copy link
Contributor

@indiv0 indiv0 commented May 11, 2022

Pull Request Description

Linking a rust_binary that depends on two cc_libraries with the same name fails. This bug is breaking cross-compiles of the enso-cloud crates.

Cause:

  1. The enso-cloud-deploy crate depends on the ide-ci crate.
  2. The ide-ci crate shares a workspace with enso-build.
  3. Both ide-ci and enso-build depend on octocrab (this crate).
  4. octocrab uses reqwest with default features enabled.
  5. reqwest's default features provide TLS through the native-tls crate.
  6. The native-tls crate depends on openssl, which depends on the libcrypto and libssl native libraries.
  7. Depending on libcrypto/libssl twice breaks the build.

This PR switches octocrab to using reqwest with rustls instead of native-tls. This removes the openssl dependency entirely.

Closes https://www.pivotaltracker.com/story/show/182135510.

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All code has been tested:
    • Unit tests have been written where possible.

@indiv0 indiv0 marked this pull request as ready for review May 11, 2022 03:26
@indiv0 indiv0 requested a review from mwu-tow as a code owner May 11, 2022 03:26
@mwu-tow mwu-tow merged commit 7fb875b into enso-org:wip/mwu/new-ide-build May 11, 2022
@indiv0 indiv0 deleted the wip/npekin/disable-native-tls-182135510 branch May 11, 2022 10:07
@indiv0 indiv0 restored the wip/npekin/disable-native-tls-182135510 branch May 11, 2022 10:07
@indiv0 indiv0 deleted the wip/npekin/disable-native-tls-182135510 branch May 11, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants