Disable native-tls in favour of rustls #4
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Linking a rust_binary that depends on two cc_libraries with the same name fails. This bug is breaking cross-compiles of the
enso-cloud
crates.Cause:
enso-cloud-deploy
crate depends on theide-ci
crate.ide-ci
crate shares a workspace withenso-build
.ide-ci
andenso-build
depend onoctocrab
(this crate).octocrab
usesreqwest
with default features enabled.reqwest
's default features provide TLS through thenative-tls
crate.native-tls
crate depends onopenssl
, which depends on thelibcrypto
andlibssl
native libraries.libcrypto
/libssl
twice breaks the build.This PR switches
octocrab
to usingreqwest
withrustls
instead ofnative-tls
. This removes theopenssl
dependency entirely.Closes https://www.pivotaltracker.com/story/show/182135510.
Important Notes
Checklist
Please include the following checklist in your PR:
Unit tests have been written where possible.