Skip to content
This repository has been archived by the owner on May 9, 2022. It is now read-only.

Try to use one common node_modules for as many dependencies as possible #45

Closed
espen42 opened this issue Mar 15, 2021 · 1 comment
Closed

Try to use one common node_modules for as many dependencies as possible #45

espen42 opened this issue Mar 15, 2021 · 1 comment
Assignees
@espen42
Labels
research

Comments

@espen42
Copy link
Contributor

espen42 commented Mar 15, 2021

Dependabot runs amok on this project because there's one root project and seven subprojects, each with a package.json of their own and a node_modules. Many of the dependencies are the same. Project maintenance will get MUCH easier (and there will be less dependabot noise) if many of the dependencies can use dependencies from one common node_modules at the root.
espen42 added a commit that referenced this issue Mar 15, 2021
@espen42
#45: trying to make buildcomponents package use dependencies from roo…
370f088 
…t node_modules.
@espen42
Copy link
Contributor Author

espen42 commented Mar 15, 2021

Builds, but mocha fails at testing:

>  mocha --require @babel/register --require @babel/polyfill --require packages/buildcomponents/test/test_helper.js "packages/buildcomponents/test/**/*@(spec.js)"
/Users/espenjobb/source/_npm_libs/react4xp-mono/packages/buildcomponents/test/build_entries_and_chunks_spec.js:1
import { expect } from 'chai';
^^^^^^

SyntaxError: Cannot use import statement outside a module
    at wrapSafe (internal/modules/cjs/loader.js:915:16)
    at Module._compile (internal/modules/cjs/loader.js:963:27)
    at Module._compile (/Users/espenjobb/source/_npm_libs/react4xp-mono/node_modules/pirates/lib/index.js:99:24)
    at Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
    at Object.newLoader [as .js] (/Users/espenjobb/source/_npm_libs/react4xp-mono/node_modules/pirates/lib/index.js:104:7)
    at Module.load (internal/modules/cjs/loader.js:863:32)
    at Function.Module._load (internal/modules/cjs/loader.js:708:14)
    at Module.require (internal/modules/cjs/loader.js:887:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at /Users/espenjobb/source/_npm_libs/react4xp-mono/node_modules/mocha/lib/mocha.js:250:27
    at Array.forEach (<anonymous>)
    at Mocha.loadFiles (/Users/espenjobb/source/_npm_libs/react4xp-mono/node_modules/mocha/lib/mocha.js:247:14)
    at Mocha.run (/Users/espenjobb/source/_npm_libs/react4xp-mono/node_modules/mocha/lib/mocha.js:576:10)
    at Object.<anonymous> (/Users/espenjobb/source/_npm_libs/react4xp-mono/node_modules/mocha/bin/_mocha:637:18)
    at Module._compile (internal/modules/cjs/loader.js:999:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
    at Module.load (internal/modules/cjs/loader.js:863:32)
    at Function.Module._load (internal/modules/cjs/loader.js:708:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:60:12)
    at internal/main/run_main_module.js:17:47

@espen42 espen42 self-assigned this Mar 15, 2021
espen42 added a commit that referenced this issue Mar 16, 2021
@espen42
#45: upgrade mocha. Still doesnt work.
d5b762c
espen42 added a commit that referenced this issue Mar 16, 2021
@espen42
#45: appears to work
6ffb91e
espen42 added a commit that referenced this issue Mar 17, 2021
@espen42
#45: needed remake after clean. Working with making npm run test:raw …
9ab69a9 
…work
espen42 added a commit that referenced this issue Mar 17, 2021
@espen42
#45: Project root level takes over node_modules, sets up symlinks in …
091d1db 
…packages/*. Packages should not run npm install during development - always run gradle npmInstall from the root and keep the root's package.json up to date with all the dependencies: {} under packages/* (dependencies should be both places - but not DEVdependencies). Also, keep the root's package.json up to date with all the DEVdependencies that are used under packages/* (DEVdependencies needed by packages/* should not be declared in the package.json under the specific packages/*, but in the root's package.json).
espen42 added a commit that referenced this issue Mar 17, 2021
@espen42
#45: packages/constants refactored, so far seems to work: gradlew bui…
b7ba4d2 
…ld, clean, lint and test
espen42 added a commit that referenced this issue Mar 17, 2021
@espen42
#45: packages/* refactored, so far seems to work: gradlew build, clea…
0368853 
…n, lint and test
espen42 added a commit that referenced this issue Mar 17, 2021
@espen42
#45 cleanup: remove some deprecated build steps
74e7cac
espen42 added a commit that referenced this issue Mar 17, 2021
@espen42
#45: untested, but versionAndPublish task sequence is tightened and d…
f39ecd5 
…ocumented.
espen42 added a commit that referenced this issue Mar 18, 2021
@espen42
#45: untested, improve versionAndPublish by adding opportunity for ma…
ddb219f 
…nually verifying the levels and interdependencies
espen42 added a commit that referenced this issue Mar 18, 2021
@espen42
#45: npm scripts npmLink and npmUnlink handles all crosslinking, and …
797edd3 
…is integrated with gradle task npmInstall, so it's better to use that than 'npm i'
espen42 added a commit that referenced this issue Mar 18, 2021
@espen42
Merge branch '#45/simplify_node_modules'
7edd05e 
* #45/simplify_node_modules:
  #45: npm scripts npmLink and npmUnlink handles all crosslinking, and is integrated with gradle task npmInstall, so it's better to use that than 'npm i'
  Readme: clean command
  #45: untested, improve versionAndPublish by adding opportunity for manually verifying the levels and interdependencies
  #45: untested, but versionAndPublish task sequence is tightened and documented.
  #45 cleanup: remove some deprecated build steps
  #45: packages/* refactored, so far seems to work: gradlew build, clean, lint and test
  #45: packages/constants refactored, so far seems to work: gradlew build, clean, lint and test
  #45: Project root level takes over node_modules, sets up symlinks in packages/*. Packages should not run npm install during development - always run gradle npmInstall from the root and keep the root's package.json up to date with all the dependencies: {} under packages/* (dependencies should be both places - but not DEVdependencies). Also, keep the root's package.json up to date with all the DEVdependencies that are used under packages/* (DEVdependencies needed by packages/* should not be declared in the package.json under the specific packages/*, but in the root's package.json).
  #45: needed remake after clean. Working with making npm run test:raw work
  #45: appears to work
  #45: upgrade mocha. Still doesnt work.
  #45: trying to make buildcomponents package use dependencies from root node_modules.
  NPM update
espen42 added a commit that referenced this issue Apr 12, 2021
@espen42
#45: NPM updates. Tested this build, did not work. Unclear error, thi…
e2c993c 
…s update might not even be the problem.
espen42 added a commit that referenced this issue Apr 19, 2021
@espen42
Merge branch '#45/common_node_modules'
5902c02 
* #45/common_node_modules:
  Docs: updates to build commands
  Feat: Improved build both locally and in included .gradle files: now more consistent across projects.
  Feat: included .gradle files parse and react to CLI overrides -Pdev(elopment) and -Pprod(uction) and -Pverbose, making those omittable from react4xp.properties and lowering risk of releasing dev code to prod.
  Chore: code whitespace
  Chore: code whitespace
  Chore: code whitespace
  #45: NPM updates. Tested this build, did not work. Unclear error, this update might not even be the problem.
  Dependabot updates. Passes local unit tests.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@espen42 espen42

Labels
research
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@espen42 @alansemenov