-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce duplicated code and expose a function for getting the enonic home dir #571
base: master
Are you sure you want to change the base?
Conversation
Hi @eiriksm ! Thank you for the effort ! Would you be interested to extend your PR with actual override mechanic as you see it ? NB. Overriding the default folder might get a bit tricky in case of running in snapcraft where we create a symlink to |
Sure Here is the updated logic, including a test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
Just a couple of minor things:
Add new env var to the table here
Line 18 in f4692a9
|`ENONIC_CLI_REMOTE_URL` |
No idea how to build the docs, but attempted to add it there. Updated the var name, and made it a const |
Thanks ! Looks good ! |
This fixes #570
So if I wanted to make sure the directory was possible to override, I would first consolidate all different places the path to $HOME/.enonic was found.
Here is a first attempt to do that. Plus some actual tests for this repo