Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website shouldn't be a workspace #611

Merged
merged 5 commits into from
Jan 10, 2025
Merged

Website shouldn't be a workspace #611

merged 5 commits into from
Jan 10, 2025

Conversation

enisdenjo
Copy link
Owner

  • Changesets wrongly detect this to be a monorepo if there's a workspaces definition
    • Doesnt correctly detect this is a single-package repo
      • Causes wrong release tags
      • Causes incorrect release notes
  • The workspaces in the package.json definition mustn't be published - complicating the release process

@enisdenjo enisdenjo marked this pull request as draft January 9, 2025 22:42
Copy link
Contributor

github-actions bot commented Jan 10, 2025

💻 Website Preview

The latest changes are available as preview in: https://5fc118f1.graphql-ws.pages.dev

@enisdenjo enisdenjo marked this pull request as ready for review January 10, 2025 13:46
@theguild-bot
Copy link
Collaborator

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
graphql-ws 5.16.2-alpha-722b4a254014b433f6c27021fb15a36c1552971d npm ↗︎ unpkg ↗︎

@enisdenjo enisdenjo merged commit 6a5fde1 into master Jan 10, 2025
10 checks passed
@enisdenjo enisdenjo deleted the website-no-wsp branch January 10, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants