Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolves #113 Added source location information to warnings #114

Merged
merged 4 commits into from
Jan 7, 2020
Merged

resolves #113 Added source location information to warnings #114

merged 4 commits into from
Jan 7, 2020

Conversation

yin
Copy link
Contributor

@yin yin commented Jan 6, 2020

The error messages are missing source locations for ease of navigating. This PR add to every logged error: Source filename (not the path), line number, and column number:

[TSD-JSDoc] dataset.js:619:4 Failed to find parent of doclet 'DatasetLocal#_getItemIndexes' using memberof 'DatasetLocal', this is likely due to invalid JSDoc.
[TSD-JSDoc] dataset.js:630:4 Failed to find parent of doclet 'DatasetLocal#_readAndParseFile' using memberof 'DatasetLocal', this is likely due to invalid JSDoc.
[TSD-JSDoc] stealth.js:40:0 Failed to find parent of doclet 'module.exports' using memberof 'module', this is likely due to invalid JSDoc.
[TSD-JSDoc] autoscaled_pool.js:209:4 Unable to resolve type for AutoscaledPool#minConcurrency, none specified in JSDoc. Defaulting to `any`.

Please review and comment.

englercj
englercj requested changes Jan 6, 2020
View reviewed changes
Copy link
Owner

@englercj englercj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea! Thanks for putting this together. Just had a few small suggestions.

yin and others added 3 commits January 6, 2020 20:53
@yin
Copy link
Contributor Author

yin commented Jan 6, 2020

I fully agree.

@englercj englercj merged commit a8a4c63 into englercj:master Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@englercj englercj englercj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yin @englercj