Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(cache-client): add authorization tests #596

Merged
merged 3 commits into from
Jul 8, 2022
Merged

test(cache-client): add authorization tests #596

merged 3 commits into from
Jul 8, 2022

Conversation

Harasz
Copy link
Contributor

@Harasz Harasz commented Jul 7, 2022 •
edited
Loading

Description

Contributor checklist

  • Breaking changes - check for any existing interfaces changes that are not backward compatible, removed method etc.
  • Documentation - document your code, add comments for method, remember to check if auto generated docs were updated.
  • Tests - add new or updated existed test for changes you made.
  • Migration guide - add migration guide for every breaking change.
  • Configuration correctness - check that any configuration changes are correct ex. default URLs, chain ids, smart contract verification on Volta explorer or EWC explorer.

@Harasz Harasz force-pushed the task/ICL-300-auth-test branch from a24a705 to 2a31e23 Compare July 8, 2022 07:50
@Harasz Harasz force-pushed the task/ICL-300-auth-test branch 2 times, most recently from 12b2323 to fe3eec7 Compare July 8, 2022 09:54
JGiter
JGiter reviewed Jul 8, 2022
View reviewed changes
Copy link
Collaborator

@JGiter JGiter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description of handleRequestError is not up-to-date. Taking chance we can fix this as well as method name

src/modules/cache-client/cache-client.service.ts Show resolved Hide resolved
src/modules/cache-client/cache-client.service.ts Show resolved Hide resolved
src/modules/cache-client/cache-client.service.ts Show resolved Hide resolved
@Harasz Harasz force-pushed the task/ICL-300-auth-test branch from 862740b to 08663fc Compare July 8, 2022 12:14
@Harasz Harasz requested a review from JGiter July 8, 2022 12:27
@Harasz Harasz merged commit e378cb3 into task/ICL-299-auth-promise-retry Jul 8, 2022
@Harasz Harasz deleted the task/ICL-300-auth-test branch July 8, 2022 12:45
Harasz added a commit that referenced this pull request Jul 8, 2022
@Harasz
chore: refactor cache client auth flow (#589)
fcbd34e 
* chore: refactor cache client auth flow

* test(cache-client): add authorization tests (#596)

* chore(cache-client): refactor request error handler

* test(cache-client): add authorization tests

* chore: use correct logger methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JGiter JGiter JGiter approved these changes

@jrhender jrhender Awaiting requested review from jrhender

@whitneypurdum whitneypurdum Awaiting requested review from whitneypurdum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Harasz @JGiter