feature/upgrade ethers to v5 #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JGiter
force-pushed
the
feature/ICL-57_upgrade_ethers_to_v5
branch
2 times, most recently
from
0b6d014 to
75c08c8
Compare
JGiter
force-pushed
the
feature/ICL-57_upgrade_ethers_to_v5
branch
from
75c08c8 to
f81076f
Compare
src/iam/iam-base.ts
Outdated
| if (!rpcUrl) { | ||
| throw new Error(ERROR_MESSAGES.NO_RPC_URL); | ||
| if (!privateKey || !rpcUrl) { | ||
| throw new Error(ERROR_MESSAGES.CONNECTION_OPTIONS_IN_NODE_NOT_PROVIDED); |
There was a problem hiding this comment.
I'm thinking that it might probably be best to let the user know what is missing rather making the error message too generic.
There was a problem hiding this comment.
@ahmedolaibrahim I am thinking if this is the case when lib is not executing in browser !this._runningInBrowser , then how we are going to send a message to user end? or is there a need to do it in this case?
There was a problem hiding this comment.
@hrachocode so what I am referring to is that the error messages for when privateKey is missing should be diff from the error message for when rpcUrl is missing. that way the user knows what to change rather than guessing which is missing.
hrachocode
approved these changes
Aug 19, 2021
ahmedolaibrahim
approved these changes
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ethersandethers-dependent packages -@ew-did-registry/*and@energyweb/iam-contracts