yaml_dataをメモ化

enechange · Apr 22, 2023 · 9286a10 · 9286a10
1 parent 9fad181
commit 9286a10
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/serverside_challenge_1/challenges/sonoki/app/controllers/api/v1/costs_controller.rb b/serverside_challenge_1/challenges/sonoki/app/controllers/api/v1/costs_controller.rb
@@ -2,18 +2,17 @@ class Api::V1::CostsController < ApplicationController
   require 'yaml'
 
   def index
-    yaml_data = YAML.load_file(yaml_path)
     render json: {
       status: 'SUCCESS',
       message: '電力会社とコスト一覧の取得に成功しました',
       data: yaml_data
     }, status: 200
   end
 
-  def calculate_rate
+  def calculate_rate # 10行で収める その他はモデルに移動
     contract_ampere = params[:contract_ampere].to_i
     usage = params[:usage].to_i unless params[:usage].nil?
-    rates = YAML.load_file(yaml_path)
+    rates = yaml_data
 
     if contract_ampere.zero? || usage.nil?
       render json: { error: 'Invalid input: contract_ampere and usage are required' }, status: 400
@@ -51,8 +50,8 @@ def calculate_rate
 
   private
 
-  def yaml_path
-    @yaml_path ||= Rails.root.join('config', 'rates.yml')
+  def yaml_data
+    yaml_data ||= YAML.load_file(Rails.root.join('config', 'rates.yml'))
   end
 
 end
diff --git a/serverside_challenge_1/challenges/sonoki/app/controllers/simulations_controller.rb b/serverside_challenge_1/challenges/sonoki/app/controllers/simulations_controller.rb
@@ -20,7 +20,7 @@ def output
       end
       data = JSON.parse(response.body)
       @results = data
-      if @results.empty?
+      if @results.empty? # TODO モデルでバリデーションする ヒント: オブジェクト指向
         render :input
       end
     end