Support "downloading" a content pack without an internet connection #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally, the same code was used in two different components. https://phabricator.endlessm.com/T35137
By using a new `isDownloadRequired` property in the get_collection_info API, we can determine ahead of time if the selected content pack will require an internet connection. Using that information, we can disable the Download button only if a connection is required. https://phabricator.endlessm.com/T35137
By using generators instead of functions returning lists, we enable a small performance optimization when determining if a download is required. https://phabricator.endlessm.com/T35137
dylanmccall
force-pushed
the
T35137-download-when-offline
branch
from
5e92fd2 to
0b773ee
Compare
manuq
reviewed
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://phabricator.endlessm.com/T35137