-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating a new Reviewing PRs wiki page #95
Conversation
Thanks for doing this! |
Thanks TheGiraffe3 & roadrunner56! Co-authored-by: Loymdayddaud <[email protected]> Co-authored-by: roadrunner56 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great ideas, thanks! I added a tip bullet pointing to the style guide & wiki more generally, and linked resources for creating a Github account/reviewing your first PR. I think those suggestions will help first time contributors a lot with getting started!
Co-authored-by: Loymdayddaud <[email protected]>
Co-authored-by: roadrunner56 <[email protected]>
Co-authored-by: roadrunner56 <[email protected]>
Co-authored-by: roadrunner56 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't actually done any spelling or grammar checking on this (at least not yet), but I approve of my writing being used in this context.
This reverts commit d32c833.
Correction/Clarification?
Summary
Saugia & roadrunner56 suggested in another PR comment thread that it could be valuable to add a wiki page around PR reviewing, so here it is!
mOctave wrote a superb set of tips for reviewers last year, so I've shamelessly linked it here and added a slightly condensed version to this doc. Definitely want any thoughts or tweaks since this is essentially those same tips.