Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CI): Add workflow for building the Steam depot #410

Merged
merged 9 commits into from
Jun 22, 2024

Conversation

tibetiroka
Copy link
Member

Adds a workflow for building the Steam depot. This is currently triggered manually.

I will test that it creates the depot with the correct contents.

@tibetiroka
Copy link
Member Author

Works. The generated steam depot can be checked in this workflow.

@tibetiroka
Copy link
Member Author

By the way, I could move this over to the release workflow in the main repo. Would that be more convenient?

@warp-core
Copy link
Contributor

That'd be a question for @MCOfficer since he's the one that does that.
Since we don't run any workflows for a release over here, it certainly seems like it'd be more convenient to have it over there where we run that workflow anyway.
But, it might be odd/confusing for something related to this package to be in that repository. And, it's not really a big inconvenience to come over here and run a workflow.

@MCOfficer
Copy link
Contributor

MCOfficer commented Jun 8, 2024

IMO the arguments for here or there kinda balance each other out, so let's pick the option with less (code) complexity and have it be here.

@Amazinite Amazinite merged commit c0bd9fa into endless-sky:master Jun 22, 2024
1 check passed
@tibetiroka tibetiroka deleted the steam branch June 22, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants