Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the outfitter key assets for endless-sky PR 10743 #186

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Updated the outfitter key assets for endless-sky PR 10743 #186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
62598fa
Updated the outfitter key assets
xobes Nov 6, 2024
024aa76
fix background transparency
xobes Nov 6, 2024
667c157
Updated outfitter key.svg/.xcf to proper size.
xobes Nov 6, 2024
27b7e91
Reapplied shading via .xcf to outfitter key.png and outfitter [email protected]
xobes Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
150 changes: 90 additions & 60 deletions ui/outfitter key.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ui/outfitter key.xcf
View file
Open in desktop
Binary file not shown.
Binary file added ui/outfitter [email protected]
View file
Open in desktop
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it expected to have a @2x file in the regular asset repo?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question.
xobes, the 2x should probably be in a PR to the high dpi plugin.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, the corresponding PR is over there: endless-sky/endless-sky-high-dpi#430

Copy link
Author

@xobes xobes Nov 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I opened the .xcf file to apply shading, it was already sized for the @2x png, so I saved it off with a more appropriate name before re-sizing and applying to the regular sprite (and saving over the formerly @2x sized wrongly named .xcf file).

Perhaps I don't understand how these things are managed...
I thought that there was ONE source https://github.com/endless-sky/endless-sky-assets that drove two repositories

  1. normal resolution: https://github.com/endless-sky/endless-sky
  2. hi res @2x: https://github.com/endless-sky/endless-sky-high-dpi

The assets repo, from my understanding exists to make ALL assets of all sizes -- that or we have two sources and I don't know about the other one.

The .xcf file(s) exists to apply shadow to the output from the .svg, which I thought was the basis for both resolutions.

This PR (#186) is for the source material, which now has a .xcf file scaled for each resolution for the application of shading to the pristine .svg source to generate .png files which then go to the two repositories for resulting sprites.

@TheGiraffe3

Good question. xobes, the 2x should probably be in a PR to the high dpi plugin.

^-- your link is to the main repo, not the plugin.

Binary file not shown.