Avoid test dependency on typing_extensions #2590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
reviewed
Mar 5, 2025
tests/protocols/test_websocket.py
Outdated
| from typing_extensions import TypedDict | ||
| from typing import TypedDict |
There was a problem hiding this comment.
I think you need to use typing.TypedDict instead of changing the import.
There was a problem hiding this comment.
Ah I see, typing is already imported further up. Will adjust.
TypedDict was added to the standard library typing module in Python 3.8. Since this project already requires at least Python 3.9, we can rely on this being available.
carlwgeorge
force-pushed
the
test-without-typing_extensions
branch
from
893ca34 to
a4e5463
Compare
Kludex
approved these changes
Mar 5, 2025
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TypedDict was added to the standard library typing module in Python 3.8. Since this project already requires at least Python 3.9, we can rely on this being available.
Previous discussed in #2589.
Checklist