Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the issue of unable to reload using pycharm #2211

Closed
wants to merge 2 commits into from
Closed

Fixed the issue of unable to reload using pycharm #2211

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b53c461
Update basereload.py
liuyiyangwang Jan 3, 2024
5df954f
Merge branch 'master' into master
liuyiyangwang Jan 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions uvicorn/supervisors/basereload.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,14 +87,8 @@ def startup(self) -> None:
self.process.start()

def restart(self) -> None:
if sys.platform == "win32": # pragma: py-not-win32
self.is_restarting = True
assert self.process.pid is not None
os.kill(self.process.pid, signal.CTRL_C_EVENT)
else: # pragma: py-win32
self.process.terminate()
self.process.terminate()
self.process.join()

self.process = get_subprocess(
config=self.config, target=self.target, sockets=self.sockets
)
Expand Down