Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create types module inside tests #2502

Merged
merged 12 commits into from
Jul 27, 2024
Merged

Create types module inside tests #2502

merged 12 commits into from
Jul 27, 2024

Conversation

TechNiick
Copy link
Contributor

Summary

This PR is related to this issue.
Moved all types used inside tests module, in a types module.

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

Kludex
Kludex reviewed Feb 10, 2024
View reviewed changes
tests/test_types/types.py Outdated Show resolved Hide resolved
Kludex
Kludex requested changes Feb 17, 2024
View reviewed changes
tests/types.py Outdated Show resolved Hide resolved
Kludex
Kludex reviewed Feb 17, 2024
View reviewed changes
tests/types.py Outdated Show resolved Hide resolved
@TechNiick TechNiick requested a review from Kludex February 17, 2024 17:04
Kludex
Kludex reviewed Feb 17, 2024
View reviewed changes
tests/types.py Outdated Show resolved Hide resolved
@TechNiick TechNiick requested a review from Kludex February 26, 2024 20:03
Kludex
Kludex reviewed Feb 29, 2024
View reviewed changes
tests/types.py Outdated Show resolved Hide resolved
@TechNiick TechNiick requested a review from Kludex March 3, 2024 17:03
@Kludex Kludex force-pushed the improve-types/types-file branch from 9cbf5f4 to 04d1fa7 Compare July 27, 2024 09:26
@Kludex Kludex merged commit 78fcd54 into encode:master Jul 27, 2024
5 checks passed
nixroxursox pushed a commit to nixroxursox/starlette that referenced this pull request Sep 30, 2024
@TechNiick @Kludex
Create types module inside tests (encode#2502)
443ab58 
* Create types module inside tests

* Apply suggestions from code review

* Apply suggestions from code review

* Fix check errors

* Change testclientfactory due to autotest

* No cover fix

* Apply suggestions from code review

* Skip code coverage for TestClientFactory protocol

* Apply suggestions from code review

* Small improvements

* Lint

* Fix everything

---------

Co-authored-by: Scirlat Danut <[email protected]>
Co-authored-by: Marcelo Trylesinski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kludex Kludex Kludex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TechNiick @Kludex