Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement RetryConfig [WIP] #134

Closed
wants to merge 1 commit into from
Closed

Implement RetryConfig [WIP] #134

wants to merge 1 commit into from

Conversation

sethmlarson
Copy link
Contributor

Early WIP not ready for review yet. Closes #108.

@StephenBrown2
Copy link
Contributor

What's the status of this? Not impatient, just curious if it'll make it into 0.6.9 :-)

@sethmlarson
Copy link
Contributor Author

I've got some local changes but I've been mostly doing maintenance work for the project the past few days. I think tomorrow I'll have a block of time I can devote to working more on it. I'd also like to see it be released soon so we can get feedback early :)

@tomchristie
Copy link
Member

My rough sense on this is that it should make it in at some point, but that we should be focusing on a narrowly-as-possible scoped 1.0 beta release, and that this is over-stretch.

I don't want us to give ourselves loads of API surface area too early on.

Plus I think that we might want to take a bit of a look more generally at the dispatcher API / if we need some other middleware or hooks interface / if the redirect logic can be more neatly encapsulated as a middleware-ish layer.

If anything we may want to start by ensuring that our dispatcher API or anything else we introduce at that kind of level is sufficiently fit-for-purpose that stuff like retries can by implemented as a third party pacakge if needed.

@sethmlarson
Copy link
Contributor Author

Sure, I'll close this for now. We can revisit later!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retry requests
3 participants