support render_postcompile (#378)

encode · Sep 2, 2021 · 1f7ca7b · 1f7ca7b
1 parent b4cd10c
commit 1f7ca7b
Show file tree

Hide file tree

Showing 5 changed files with 29 additions and 4 deletions.
diff --git a/databases/backends/aiopg.py b/databases/backends/aiopg.py
@@ -199,7 +199,9 @@ def transaction(self) -> TransactionBackend:
     def _compile(
         self, query: ClauseElement
     ) -> typing.Tuple[str, dict, CompilationContext]:
-        compiled = query.compile(dialect=self._dialect)
+        compiled = query.compile(
+            dialect=self._dialect, compile_kwargs={"render_postcompile": True}
+        )
 
         execution_context = self._dialect.execution_ctx_cls()
         execution_context.dialect = self._dialect

diff --git a/databases/backends/mysql.py b/databases/backends/mysql.py
@@ -189,7 +189,9 @@ def transaction(self) -> TransactionBackend:
     def _compile(
         self, query: ClauseElement
     ) -> typing.Tuple[str, dict, CompilationContext]:
-        compiled = query.compile(dialect=self._dialect)
+        compiled = query.compile(
+            dialect=self._dialect, compile_kwargs={"render_postcompile": True}
+        )
 
         execution_context = self._dialect.execution_ctx_cls()
         execution_context.dialect = self._dialect

diff --git a/databases/backends/postgres.py b/databases/backends/postgres.py
@@ -231,7 +231,9 @@ def transaction(self) -> TransactionBackend:
         return PostgresTransaction(connection=self)
 
     def _compile(self, query: ClauseElement) -> typing.Tuple[str, list, tuple]:
-        compiled = query.compile(dialect=self._dialect)
+        compiled = query.compile(
+            dialect=self._dialect, compile_kwargs={"render_postcompile": True}
+        )
 
         if not isinstance(query, DDLElement):
             compiled_params = sorted(compiled.params.items())

diff --git a/databases/backends/sqlite.py b/databases/backends/sqlite.py
@@ -157,7 +157,9 @@ def transaction(self) -> TransactionBackend:
     def _compile(
         self, query: ClauseElement
     ) -> typing.Tuple[str, list, CompilationContext]:
-        compiled = query.compile(dialect=self._dialect)
+        compiled = query.compile(
+            dialect=self._dialect, compile_kwargs={"render_postcompile": True}
+        )
 
         execution_context = self._dialect.execution_ctx_cls()
         execution_context.dialect = self._dialect

diff --git a/tests/test_databases.py b/tests/test_databases.py
@@ -1061,3 +1061,20 @@ async def test_posgres_interface(database_url):
             ):
                 # avoid checking `id` at index 0 since it may change depending on the launched tests
                 assert list(result.values())[1:] == ["example1", True]
+
+
+@pytest.mark.parametrize("database_url", DATABASE_URLS)
+@async_adapter
+async def test_postcompile_queries(database_url):
+    """
+    Since SQLAlchemy 1.4, IN operators needs to do render_postcompile
+    """
+    async with Database(database_url) as database:
+        query = notes.insert()
+        values = {"text": "example1", "completed": True}
+        await database.execute(query, values)
+
+        query = notes.select().where(notes.c.id.in_([2, 3]))
+        results = await database.fetch_all(query=query)
+
+        assert len(results) == 0