-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WRQ-14123: Fixed performanceMEtrics when same component is selected once more. Fixed tests where results were saved in the wrong file #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed tests where the tests results were saved in the wrong file
adrian-cocoara-lgp
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hong6316
pushed a commit
that referenced
this pull request
Apr 15, 2024
* WRQ-8596: Adapt performanceMetrics app for Agate performance tests (#81) * added performance tests for agate components * code review fixes * Adapted performanceMetrics app for Agate test results * code review fixes * fixed urls for performanceMetrics * WRQ-11737: Added performance tests for agate overall view + fixes for other tests (#82) * avoided unnecessary api call when the theme library is changed in poerformanceMetrics * Added overallView for Agate Fixed lint warnings for latest enact/cli Fixed placeholder images link * Added tests for agate/overallview Solved lint warnings * modified marquee test in order to fix the tests on jenkins * revert for marquee test * fix for marquee test * fix for sandstone/marquee test * fixed tests for agate/Slider, agate/IncrementSlider, sandstone/Slider and sandstone/Panels * fixed tests for agate/Panels * code review fixes * WRQ-14123: Fixed performanceMetrics when same component is selected once more. Fixed tests where results were saved in the wrong file (#83) * fixed performanceMetrics when same component is selected once more. Fixed tests where the tests results were saved in the wrong file * Fixed performance tests where the metric name was incorrect * Added missing component options in performance metrics dropdown * WRQ-16517: Updated dependencies to fix critical vulnerabilities (#84) * updated dependencies to fix vulnerabilities * fixed quickguidepanel test view
daniel-stoian-lgp
added a commit
that referenced
this pull request
Aug 22, 2024
* WRQ-8596: Adapt performanceMetrics app for Agate performance tests (#81) * added performance tests for agate components * code review fixes * Adapted performanceMetrics app for Agate test results * code review fixes * fixed urls for performanceMetrics * WRQ-11737: Added performance tests for agate overall view + fixes for other tests (#82) * avoided unnecessary api call when the theme library is changed in poerformanceMetrics * Added overallView for Agate Fixed lint warnings for latest enact/cli Fixed placeholder images link * Added tests for agate/overallview Solved lint warnings * modified marquee test in order to fix the tests on jenkins * revert for marquee test * fix for marquee test * fix for sandstone/marquee test * fixed tests for agate/Slider, agate/IncrementSlider, sandstone/Slider and sandstone/Panels * fixed tests for agate/Panels * code review fixes * WRQ-14123: Fixed performanceMetrics when same component is selected once more. Fixed tests where results were saved in the wrong file (#83) * fixed performanceMetrics when same component is selected once more. Fixed tests where the tests results were saved in the wrong file * Fixed performance tests where the metric name was incorrect * Added missing component options in performance metrics dropdown * WRQ-16517: Updated dependencies to fix critical vulnerabilities (#84) * updated dependencies to fix vulnerabilities * fixed quickguidepanel test view * WRQ-18593: Changed chart configuration to show all labels and lines (#86) * updated configuration for chart xAxis * reverted chart width * changed xAxis interval and chart size * fix enact link on sandstone (#87) * Fix QuickGuidePanel import statement to Panel (#88) Enact-DCO-1.0-Signed-off-by: Juwon Jeong ([email protected]) * WRQ-25865: Updated package dependencies to fix security vulnerabilities (#93) * Update package dependencies to fix security vulnerabilities * Updated `react-router-dom` dependency * WRQ-31596: Fix Critical and High vulnerabilities in agate (#94) * updated package-lock * fixed package-lock * updated package.json --------- Co-authored-by: Daniel Stoian <[email protected]> --------- Co-authored-by: adrian-cocoara-lgp <[email protected]> Co-authored-by: Juwon Jeong <[email protected]> Co-authored-by: ion-andrusciac-lgp <[email protected]> Co-authored-by: paul-beldean-lgp <[email protected]>
daniel-stoian-lgp
added a commit
that referenced
this pull request
Oct 16, 2024
* WRQ-8596: Adapt performanceMetrics app for Agate performance tests (#81) * added performance tests for agate components * code review fixes * Adapted performanceMetrics app for Agate test results * code review fixes * fixed urls for performanceMetrics * WRQ-11737: Added performance tests for agate overall view + fixes for other tests (#82) * avoided unnecessary api call when the theme library is changed in poerformanceMetrics * Added overallView for Agate Fixed lint warnings for latest enact/cli Fixed placeholder images link * Added tests for agate/overallview Solved lint warnings * modified marquee test in order to fix the tests on jenkins * revert for marquee test * fix for marquee test * fix for sandstone/marquee test * fixed tests for agate/Slider, agate/IncrementSlider, sandstone/Slider and sandstone/Panels * fixed tests for agate/Panels * code review fixes * WRQ-14123: Fixed performanceMetrics when same component is selected once more. Fixed tests where results were saved in the wrong file (#83) * fixed performanceMetrics when same component is selected once more. Fixed tests where the tests results were saved in the wrong file * Fixed performance tests where the metric name was incorrect * Added missing component options in performance metrics dropdown * WRQ-16517: Updated dependencies to fix critical vulnerabilities (#84) * updated dependencies to fix vulnerabilities * fixed quickguidepanel test view * WRQ-18593: Changed chart configuration to show all labels and lines (#86) * updated configuration for chart xAxis * reverted chart width * changed xAxis interval and chart size * fix enact link on sandstone (#87) * Fix QuickGuidePanel import statement to Panel (#88) Enact-DCO-1.0-Signed-off-by: Juwon Jeong ([email protected]) * WRQ-25865: Updated package dependencies to fix security vulnerabilities (#93) * Update package dependencies to fix security vulnerabilities * Updated `react-router-dom` dependency * WRQ-31596: Fix Critical and High vulnerabilities in agate (#94) * updated package-lock * fixed package-lock * updated package.json --------- Co-authored-by: Daniel Stoian <[email protected]> * WRR-1078: Added tests for INP web vital (#92) * added support for reading interaction to next paint * Added inp performance tests * added performance tests for Agate ArcPicker --> IncrementSlider * Added INP performance tests for agate components * Added INP Metric for Performance Metrics charts * import order fix * removed commented code * updated readme * refactored inp tests to download webvitals library instead of using local code * lint fixes * adjustments for sandstone inp tests * adjustments for agate inp tests * reverse for commented tests * adjustments for sandstone inp tests * adjustments for agate inp tests * adjustments for sandstone inp tests * adjustments for sandstone inp tests * adjustments for agate inp tests * moved url of web vitals library to a global variable * minor fixes * updated views and tests for contextualpopup in order to support INP metric. fixed eslint warnings * pinned web-vitals version * WRR-2951: Removed tests for FID web-vital (#96) * Removed tests for FID web-vital * minor fixes * WRR-626: Updated puppeteer and wait-on dependencies to latest version (#97) * upgraded puppeteer to v22 * updated puppeteer to latest version * updated wait-on to latest version * Update jsdom-extended.js * changed ws dependency to 7.5.10 --------- Co-authored-by: adrian-cocoara-lgp <[email protected]> Co-authored-by: Juwon Jeong <[email protected]> Co-authored-by: ion-andrusciac-lgp <[email protected]> Co-authored-by: paul-beldean-lgp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
Fixed performanceMEtrics when same component is selected once more.
Fixed tests where results were saved in the wrong file or the metric name was incorrect
Resolution
Additional Considerations
Links
WRQ-14123
Comments
Enact-DCO-1.0-Signed-off-by: Daniel Stoian [email protected]