Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRQ-4709 : Added performance tests for agate components #79

Merged
merged 5 commits into from
Feb 1, 2024

Conversation

daniel-stoian-lgp
Copy link
Contributor

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Added performance tests for agate components

Resolution

Additional Considerations

Links

WRQ-4709

Comments

Enact-DCO-1.0-Signed-off-by: Daniel Stoian [email protected]

Copy link
Contributor

@stanca-pop-lgp stanca-pop-lgp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Effort appreciated.

Copy link
Member

@seunghoh seunghoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this PR but would you please update as follows?

  • Please add a fallback script that can test sandstone without --theme options.
    serve test test-all
  • Please check the lint error with the latest Enact CLI. I see
    "1:34 error 'PerformanceObserver' is already defined as a built-in global variable no-redeclare"
    when runs npm run lint

@daniel-stoian-lgp
Copy link
Contributor Author

daniel-stoian-lgp commented Jan 31, 2024

Not related to this PR but would you please update as follows?

  • Please add a fallback script that can test sandstone without --theme options.
    serve test test-all
  • Please check the lint error with the latest Enact CLI. I see
    "1:34 error 'PerformanceObserver' is already defined as a built-in global variable no-redeclare"
    when runs npm run lint

Hello @seunghoh

  1. I added a fallback script for serve. test and test-all already default to sandstone if no --theme is provided.
  2. I solved the lint error on the latest CLI

@seunghoh seunghoh merged commit b001733 into develop Feb 1, 2024
@seunghoh seunghoh deleted the feature/WRQ-4709-2 branch February 1, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants