-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WRQ-4709 : Added performance tests for agate components #79
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Effort appreciated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not related to this PR but would you please update as follows?
- Please add a fallback script that can test sandstone without --theme options.
serve
test
test-all
- Please check the lint error with the latest Enact CLI. I see
"1:34 error 'PerformanceObserver' is already defined as a built-in global variable no-redeclare"
when runsnpm run lint
Hello @seunghoh
|
Checklist
Issue Resolved / Feature Added
Added performance tests for agate components
Resolution
Additional Considerations
Links
WRQ-4709
Comments
Enact-DCO-1.0-Signed-off-by: Daniel Stoian [email protected]