Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some fixes #2035

Merged
merged 4 commits into from
Sep 21, 2024
Merged

some fixes #2035

merged 4 commits into from
Sep 21, 2024

Conversation

MichaelDvP
Copy link
Contributor

  • custom entities commands not working, (entityItem.name.c_str() is local and not permanent)
  • customizations naming with tags was odd, now change name but keep the tag.
  • terminal call does not show info/values for ems devices anymore

@proddy
Copy link
Contributor

proddy commented Sep 20, 2024

didn't know about the custom entities and tag, nice fix.

For the console, what was the issue with the show info/values from the console? I'll add it to the unit tests.

@MichaelDvP
Copy link
Contributor Author

what was the issue with the show info/values from the console

before the commands info/value/commands were registered for each ems-device, now these commansd are handeled by get_value_info and do not show in register.

ems-esp:# call
Showing all available commands (*=authentication not required):

 system:
  info                          list all values *
  commands                      list all commands *
  values                        list all values *
  publish                       publish all to MQTT *
  send                          send a telegram
  fetch                         refresh all EMS values
  sendmail                      send email
  restart                       restart EMS-ESP
  format                        factory reset EMS-ESP
  watch                         watch incoming telegrams *
  message                       send a message *
  response                      get response *
  allvalues                     output all values in system *

 custom:
  info                          list all values *
  commands                      list all commands *
  values                        list all values *
  test                          set custom value on ems
  ram1                          set custom value on ems
  asdfg                         set custom value on ems

 scheduler:
  info                          list all values *
  commands                      list all commands *
  values                        list all values *
  solarassist_on                enable schedule item
  solarassist_off               enable schedule item

 temperaturesensor:
  info                          list all values *
  commands                      list all commands *
  values                        list all values *

 analogsensor:
  info                          list all values *
  commands                      list all commands *
  values                        list all values *
  relais1                       digital_out
  relais2                       digital_out
  setvalue                      set io value

 boiler:
  coldshot                      send a cold shot of water
  reset                         reset
  heatingoff                    force heating off
  selflowtemp                   selected flow temperature
  outdoortemp                   outside temperature
  burnminpower                  burner min power
  burnmaxpower                  burner max power

No info/values/commands in boiler, thermostat, mixer, solar, etc.
With the fix it shows the commands. It's not an important fix.

@proddy proddy merged commit 4905047 into emsesp:dev Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants