This repository has been archived by the owner on Oct 4, 2021. It is now read-only.
feat(thermostats): display mode for FW100 and FW120 thermostats #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neonox31
deleted the
1-feat-thermostats-display-mode-for-fw100-and-fw120-thermostats
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR permits to retreive/display mode for Junkers FW100/120 thermostats.
I was able to test the code successfully with my FW120 but maybe it could be a good idea to test with a FW100 (/cc @Vuego123 )
Few information:
x006Ftype message is sent with a data length of 1, I have to ignore it in https://github.com/Neonox31/boiler/blob/589caf33bcc024514ad210ebcc5024b91f83de37/src/ems.cpp#L1524 otherwise the temperature values are reset to zeroEMS_Sys_Status.emsRefreshedflag like other models