This repository has been archived by the owner on Oct 4, 2021. It is now read-only.
fix curr temp when higher than 25.5 #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@reenx thanks for finding the issue. Question: why do you multiple the setpoint temp by 5 ? |
The original value is 2 times the human readable value. By multiplying by 5 and using a decimal of 1 (dividing by 10) I effectively divide by 2 and I do not lose the precision because of rounding. |
proddy
approved these changes
Jul 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for displaying temperatures above 25.5 degrees. This should fix issue #163 .
I tested it on my local system and there the temperatures are now correct.
Also via MQTT. Not sure why they were wrong in the first place as this is not used for mqtt as far as I can see. (Perhaps that was changed after version 1.6.0).
Anyway it all appears to work now both for mqtt as for the telnet interface.