This repository has been archived by the owner on Oct 4, 2021. It is now read-only.
Smart tx take two - refinement #116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 22, 2019 23:47
redesigned Tx logic - monitor EMSBus after sending any data
we avoid the loopback mode, but still send with interrupts disabled. So we collect all Rx chars in FIFO to allow processing. After last Rx-char we enable interrupts and send the BRK.
…mart-tx-TakeTwo * 'dev' of https://github.com/proddy/EMS-ESP-Boiler: poll from milli to micro secs for better accuracy fixed trailing ; in Tx emsesp#103 (comment) tx logic empty rx fifo after Tx BRK cleanup tx logic "take two" small change to serial for easier debugging EMS Tx del disabled tx code for mode 2 until we've fixed it susisstrolch's Tx "take two" mod
proddy
reviewed
May 27, 2019
|
Should be fixed by #119...
Sent by mobile device
… Am 27.05.2019 um 10:18 schrieb Proddy ***@***.***>:
@proddy commented on this pull request.
these changes are out of sync with the updates I made yesterday. Can you refresh emsuart.cpp and then re=apply the changes?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the send BRK loopback sniffing to a fixed amount (approx. 3char length).
Also added a watchdog counter when waiting for Rx chars