Outside temperature wrong when under 0°C

[Skeletitor]

If the outside temperature is under 0°C, then a wrong number is detected:
Console output: Outside temperature: 6552.8 C

[proddy]

good catch. I never tested for negative numbers. I checked the code it negative floats are rendered correctly so the problem is interpreting the values from the telegram. Would you mind sending me the raw data? In Verbose logging mode copy&paste a 0x19 (UBAMonitorSlow) message. Thanks

[Skeletitor]

Thanks for your quick reply.

<--- UBAMonitorSlow(0x19) received
(00:01:57) Publishing data to MQTT topics
(00:01:58) Boiler broadcast, type 0x1c len=16, data: 08 00 1c 00 00 3d b9 7b 00 00 00 00 00 00 00 74

shows 0x8000 (not available ?)

[proddy]

could you send the data from type 0x19? This has the outdoor temp in it.

…

On Tue, Dec 18, 2018 at 8:44 PM Analogiker ***@***.***> wrote: Thanks for your quick reply. <--- UBAMonitorSlow(0x19) received (00:01:57) Publishing data to MQTT topics (00:01:58) Boiler broadcast, type 0x1c len=16, data: 08 00 1c 00 00 3d b9 7b 00 00 00 00 00 00 00 74 shows 0x8000 (not available ?) — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#13 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABLHeM3SbLDFl9E8ltjQbFsP3ijBuzl8ks5u6UW0gaJpZM4ZY4Lb> .

[Skeletitor]

oh sorry

(00:28:50) Boiler broadcast, type 0x19 len=32, data: 08 00 19 00 ff f3 01 6e 80 00 00 00 00 64 02 ff f1 12 bf 14 00 00 00 0c a4 5e 02 d1 ff 00 00 e8 (OK)

[proddy]

ok got it. and whats the real temp outside roughly so I can double check?

…

On Tue, Dec 18, 2018 at 9:07 PM Analogiker ***@***.***> wrote: oh sorry (00:28:50) Boiler broadcast, type 0x19 len=32, data: 08 00 19 00 ff f3 01 6e 80 00 00 00 00 64 02 ff f1 12 bf 14 00 00 00 0c a4 5e 02 d1 ff 00 00 e8 (OK) — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#13 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABLHeA1aes4KpmBHu1kiR3IdysJp3oI1ks5u6UrrgaJpZM4ZY4Lb> .

[Skeletitor]

It's somewhat under zero °C. Depending on my position -0,5 to -0,1
(00:57:41) Boiler broadcast, type 0x19 len=32, data: 08 00 19 00 ff f2 01 7f 80 00 00 00 00 37 02 ff f3 12 bf 20 00 00 00 0c a4 6a 02 d2 01 00 00 a8 (OK)

[Skeletitor]

Year. That could be possible. I have no other outside thermostat.

…

________________________________ Von: Proddy <[email protected]> Gesendet: Dienstag, Dezember 18, 2018 9:40 PM An: proddy/EMS-ESP-Boiler Cc: Analogiker; Author Betreff: Re: [proddy/EMS-ESP-Boiler] Outside temperature wrong when under 0°C (#13) is it -1.2 ? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.jparrowsec.cn%2Fproddy%2FEMS-ESP-Boiler%2Fissues%2F13%23issuecomment-448362398&data=02%7C01%7C%7Cdbcbe23d7e1640830b7b08d665290715%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636807624211774004&sdata=qk6HoRebbNG4kaCRycRbzVvg%2B6oe62p%2FoCIOrWwdNmo%3D&reserved=0>, or mute the thread<https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.jparrowsec.cn%2Fnotifications%2Funsubscribe-auth%2FAbQHLa4r2lGNELsX4DKuUTW2snEeOd_Oks5u6VKzgaJpZM4ZY4Lb&data=02%7C01%7C%7Cdbcbe23d7e1640830b7b08d665290715%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636807624211774004&sdata=og8r4A9WEwYhYD3iT3xyMdO6u%2Bq8U5bIntAh5BGrgZk%3D&reserved=0>.

[proddy]

ok, I think I fixed it. It's hard to tell because my boiler doesn't support it. The fixed code is part of version 1.1 which I'd upload soon to github

[Skeletitor]

Proddy, great job. Thank you very much!!

I wish you some nice holidays

[proddy]

I'm still not certain if they use a 1's-complement or 2's-complement for representing negative values so the results may be off by 0.1. I'll leave this open so someone can double check and confirm.

[proddy]

fixed in latest build.