Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make main symbol optional even in STANDALONE_WASM mode #9641

Merged
merged 2 commits into from
Oct 15, 2019
Merged

Make main symbol optional even in STANDALONE_WASM mode #9641

merged 2 commits into from
Oct 15, 2019

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Oct 14, 2019 •
edited
Loading

See: #9640
Fixes: #9635

@sbc100 sbc100 requested a review from kripken October 14, 2019 19:15
kripken
kripken approved these changes Oct 14, 2019
View reviewed changes
Copy link
Member

@kripken kripken left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also put the argc/argv code behind if (main) {, so that the optimizer can remove it and have _start only run the constructors.

@sbc100 sbc100 changed the title Make main symbol options even in STANDALONE_WASM mode Make main symbol optional even in STANDALONE_WASM mode Oct 15, 2019
@sbc100 sbc100 merged commit a4d7f67 into incoming Oct 15, 2019
@delete-merged-branch delete-merged-branch bot deleted the optional_main branch October 15, 2019 00:29
belraquib pushed a commit to belraquib/emscripten that referenced this pull request Dec 23, 2020
@sbc100 @belraquib
Make main symbol optional even in STANDALONE_WASM mode (emscripten-…
ba7ed06 
…core#9641)

See: emscripten-core#9640
Fixes: emscripten-core#9635
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kripken kripken kripken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Standalone programs without main are broken
2 participants
@sbc100 @kripken