Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change OS X to macOS #6138

Merged
merged 2 commits into from
Jan 24, 2018
Merged

Change OS X to macOS #6138

merged 2 commits into from
Jan 24, 2018

Conversation

aheejin
Copy link
Member

@aheejin aheejin commented Jan 24, 2018

Apple changed the name of their OS on Mac from OS X to macOS.

@aheejin
Copy link
Member Author

aheejin commented Jan 24, 2018

Hmm, [ci skip] in the previous commit doesn't seem to work, and don't know why.
By the way, here I've mostly changed names within *.py files. There are many left in test source code, which I think is kind of OK, but also there are some more in *.rst files, which we might have to fix. In *.rst files currently the term "Mac OS X" is being used, and I'm not sure if we change this to "Mac macOS" or just "macOS". I guess latter would look better though.

@saschanaz
Copy link
Collaborator

"macOS" should be fine (as no one calls it "mac mac os" 😁).

@kripken
Copy link
Member

kripken commented Jan 24, 2018

Yeah, that's weird that [ci skip] didn't work...

@kripken kripken merged commit 1513d72 into emscripten-core:incoming Jan 24, 2018
@aheejin aheejin deleted the osx2macos branch January 24, 2018 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants