Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable NODERAWFS tests on Mac #6121

Closed
wants to merge 10 commits into from
Closed

Disable NODERAWFS tests on Mac #6121

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
46f52b9
Disable NODERAWFS tests on Mac
aheejin Jan 20, 2018
deef0c6
uppercase
aheejin Jan 20, 2018
869207f
Use is_mac() and is_windows()
aheejin Jan 20, 2018
e41f2e4
typo
aheejin Jan 20, 2018
1d8560f
Merge branch 'incoming' into disable_noderawfs_on_mac
aheejin Jan 23, 2018
6e10c36
Split the test into two
aheejin Jan 23, 2018
872c6c7
address comments
aheejin Jan 23, 2018
5d155e9
Merge branch 'incoming' into disable_noderawfs_on_mac
aheejin Jan 24, 2018
a2ee62a
OSX -> macOS
aheejin Jan 24, 2018
657f5fc
Re-enable test_fs_writeFile
aheejin Jan 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/test_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4787,7 +4787,7 @@ def test_unistd_unlink(self):
if self.is_windows() and fs == 'NODEFS': Building.COMPILER_TEST_OPTS += ['-DNO_SYMLINK=1']
self.do_run(src, 'success', force_c=True, js_engines=[NODE_JS])
# Several differences/bugs on Windows including https://github.com/nodejs/node/issues/18014
if not self.is_windows():
if not self.is_macos() and not self.is_windows():
Building.COMPILER_TEST_OPTS = orig_compiler_opts + ['-DNODERAWFS']
if not os.geteuid(): # 0 if root
Building.COMPILER_TEST_OPTS += ['-DSKIP_ACCESS_TESTS']
Expand Down