Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Wasm64] Fix many remaining issues with wasm64_4gb and add new test configuration #20077

Merged
merged 1 commit into from
Aug 22, 2023
Merged

[Wasm64] Fix many remaining issues with wasm64_4gb and add new test configuration #20077

merged 1 commit into from
Aug 22, 2023

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Aug 18, 2023 •
edited
Loading

One notable change here the change to node fs.syncRead/syncWrite
calls. Previously we were doing Buffer.from(buffer.buffer) but this
was running into the v8 limit on the size of of a typed array:

RangeError: Invalid typed array length: 4404019200
    at new Uint8Array (<anonymous>)
    at new FastBuffer (node:internal/buffer:961:5)
    at fromArrayBuffer (node:buffer:477:10)
    at Function.from (node:buffer:305:14)
    at Object.write (/tmp/emtest_40go4h7l/emscripten_test_wasm64_4gb_650u3ts9/access.js:2519:60)

The new code just makes a small array view of the range being written to
or read from.

@sbc100 sbc100 requested review from dschuff and kripken August 18, 2023 21:57
@sbc100 sbc100 force-pushed the more_more_4gb branch 3 times, most recently from 8f871c3 to cbc9a0e Compare August 18, 2023 22:01
@sbc100 sbc100 changed the title [Wasm64] Fix many remaining issues and add wasm64_4gb test configuration [Wasm64] Fix many remaining issues with wasm64_4gb and add new test configuration Aug 18, 2023
@sbc100 sbc100 force-pushed the more_more_4gb branch 4 times, most recently from edb098b to 732b70a Compare August 19, 2023 00:01
dschuff
dschuff reviewed Aug 19, 2023
View reviewed changes
@sbc100 sbc100 force-pushed the more_more_4gb branch 3 times, most recently from 206f45c to e379ab2 Compare August 19, 2023 00:10
@dschuff
Copy link
Member

dschuff commented Aug 19, 2023

oh and can you update teh commit message with some description of the kinds of changes?

@sbc100 sbc100 force-pushed the more_more_4gb branch 3 times, most recently from 89373a2 to 65aeb0c Compare August 19, 2023 02:20
@sbc100 sbc100 changed the base branch from main to more_2gb August 19, 2023 02:20
@sbc100
Copy link
Collaborator Author

sbc100 commented Aug 19, 2023

Depends on #20079

@pavshen pavshen mentioned this pull request Aug 21, 2023
Closed
kripken
kripken reviewed Aug 21, 2023
View reviewed changes
dschuff
dschuff approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@dschuff dschuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

Base automatically changed from more_2gb to main August 21, 2023 21:24
@sbc100
[Wasm64] Fix many remaining issues and add wasm64_4gb test configuration
e83bb3c 
One notable change here the change to node `fs.syncRead/syncWrite`
calls.  Previously we were doing `Buffer.from(buffer.buffer)` but this
was running into the v8 limit on the size of of a typed array:

```
RangeError: Invalid typed array length: 4404019200
```

The new code just makes a small array view of the range being written to
or read from.
@sbc100
Copy link
Collaborator Author

sbc100 commented Aug 21, 2023

@kripken any other comments?

@sbc100 sbc100 merged commit f15841d into main Aug 22, 2023
@sbc100 sbc100 deleted the more_more_4gb branch August 22, 2023 00:59
@mzoliker mzoliker mentioned this pull request Jan 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kripken kripken kripken left review comments

@dschuff dschuff dschuff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbc100 @dschuff @kripken