Skip to content

Commit

Permalink
Ignore a new clang warning on sqlite test (#11846)
Browse files Browse the repository at this point in the history
  • Loading branch information
kripken authored Aug 9, 2020
1 parent 70d1161 commit 8fb5454
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions tests/test_core.py
Original file line number Diff line number Diff line change
Expand Up @@ -6220,9 +6220,14 @@ def test_sqlite(self):
# newer clang has a warning for implicit conversions that lose information,
# which happens in sqlite (see #9138)
self.emcc_args += ['-Wno-implicit-int-float-conversion']
# temporarily ignore unknown flags, which lets the above flag be used on our CI which doesn't
# yet have the new clang with that flag
# newer clang warns about "suspicious concatenation of string literals in an
# array initialization; did you mean to separate the elements with a comma?"
self.emcc_args += ['-Wno-string-concatenation']
# ignore unknown flags, which lets the above flags be used on github CI
# before the LLVM change rolls in (the same LLVM change that adds the
# warning also starts to warn on it)
self.emcc_args += ['-Wno-unknown-warning-option']

self.emcc_args += ['-I' + path_from_root('tests', 'third_party', 'sqlite')]

src = '''
Expand Down

0 comments on commit 8fb5454

Please sign in to comment.