This repository was archived by the owner on Aug 7, 2020. It is now read-only.
Add in tini for proper signal propogation inside docker #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change adds TINI, an init manager to the docker container, this ensures that when docker stop is called, the signal gets properly propagated to the erlang process, right now only the shell script got the signal and it didn't do anything about it(resulting in a sigkill after a timeout).
With this change the erlang process will get the SIGTERM and properly shutdown.(Needs to be handled inside emqttd)
TINI was used over other init systems because it's extremely small and does the job well. (Docker uses this if you use the
--initoption).