-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support packet retransmission in QOS 1 / 2 mode #143
Comments
I guess retransmission is not supported (yet).
On 25-May-18 14:15:31, NicoWallmeier <[email protected]> wrote:
I have reviewed the qmqtt implementation and I’m wondering how QOS 1 respectively QOS 2 works if the underlying socket is not connected while the publish method is executed?
In that case the method QMQTT::Network::sendFrame would do nothing because the socket is not connected, but the method QMQTT::ClientPrivate::publish would put the message to the hash _midToMessage. I could not find that a retransmission is performed after the socket is connected again… Do I missed something?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub [#143], or mute the thread [https://github.com/notifications/unsubscribe-auth/ARpGJTnAO7fPWCgv3hC0WS7i1oNHqq8rks5t1_XigaJpZM4UN38j].
|
I'm not sure if it's the same problem. but sometimes a publish doesn't lead to a published nor to an error event (maybe due to a bad connection?) |
A call to Client::publish will cause a PUBLISH message to be sent over the TCP connection, unless the TCP connection is down at that moment (that is, we are between disconnect and reconnect), and there is no retry. I guess this is incorrect if QOS1/2 is used, but that's how it is. About the pingrequest: right now, pinging is fully automatic, there is no manual option. It is easy to implement however, the code you'll need is in |
I have reviewed the qmqtt implementation and I’m wondering how QOS 1 respectively QOS 2 works if the underlying socket is not connected while the publish method is executed?
In that case the method QMQTT::Network::sendFrame would do nothing because the socket is not connected, but the method QMQTT::ClientPrivate::publish would put the message to the hash _midToMessage. I could not find that a retransmission is performed after the socket is connected again… Do I missed something?
The text was updated successfully, but these errors were encountered: