Support timeout for stopping pools #55
Draft
+173
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terry-xiaoyu
force-pushed
the
handle-stop-pool-timeout
branch
from
bdfff99 to
6293cdf
Compare
terry-xiaoyu
changed the title
zmstone
reviewed
Nov 26, 2024
zmstone
reviewed
Nov 26, 2024
src/ecpool_sup.erl
Outdated
Comment on lines
135
to
147
| case process_info(Pid, [dictionary, status, current_function]) of | ||
| [{dictionary, Dicts}, {status, Status}, {current_function, CurrFunc}] -> | ||
| case proplists:get_value('$initial_call', Dicts) of | ||
| {supervisor, ecpool_pool_sup, _} -> | ||
| case {Status, CurrFunc} of | ||
| {waiting, {proc_lib, _, _}} -> | ||
| {ok, Pid}; | ||
| _ -> | ||
| {error, not_stuck_in_start} | ||
| end; | ||
| _ -> | ||
| search_ecpool_pool_sup_process(Rest) | ||
| end; |
There was a problem hiding this comment.
this is too error-prone, can we force the potential processes to be killed with a special key in processes dictionary ?
e.g. put('$ecpool_force_kill', true).
and with a OTP_RELEASE compile switch, we can use process label for the same purpose.
https://www.erlang.org/doc/apps/stdlib/proc_lib.html#set_label/1
There was a problem hiding this comment.
Here I want to only kill the ecpool_pool_sup processes stuck in its init() callbacks.
In this case it should be calling proc_lib:sync_start/2 (OTP 26+) or proc_lib:sync_start_link/2 (OTP 24), so I'd like to match {current_function, [{proc_lib, _, _}]} here.
terry-xiaoyu
force-pushed
the
handle-stop-pool-timeout
branch
from
5530c1d to
7fec061
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.