Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings #179

Merged
merged 4 commits into from
Jun 2, 2023
Merged

Fix warnings #179

merged 4 commits into from
Jun 2, 2023

Conversation

JaylinYu
Copy link
Member

@JaylinYu JaylinYu commented Jun 2, 2023

No description provided.

@JaylinYu JaylinYu requested review from wanghaEMQ and xinyi-xs June 2, 2023 06:01
@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Patch coverage: 4.34% and project coverage change: -0.03 ⚠️

Comparison is base (737c3b6) 59.48% compared to head (4ae05a4) 59.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #179      +/-   ##
==========================================
- Coverage   59.48%   59.45%   -0.03%     
==========================================
  Files         100      100              
  Lines       27468    27446      -22     
==========================================
- Hits        16338    16318      -20     
+ Misses      11130    11128       -2     
Impacted Files Coverage Δ
src/core/message.c 84.15% <ø> (ø)
src/mqtt/protocol/mqtt/mqtt_client.c 0.00% <0.00%> (ø)
src/mqtt/protocol/mqtt/mqttv5_quic.c 0.00% <0.00%> (ø)
src/mqtt/transport/tcp/mqtt_tcp.c 0.68% <0.00%> (ø)
src/supplemental/mqtt/mqtt_public.c 15.69% <ø> (ø)
src/supplemental/mqtt/mqtt_codec.c 41.86% <100.00%> (ø)

... and 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JaylinYu JaylinYu merged commit cbaba16 into main Jun 2, 2023
@JaylinYu JaylinYu deleted the jaylin/mark branch June 2, 2023 14:54

To enable Debug + ASAN
```bash
cmake -G Ninja -DCMAKE_BUILD_TYPE=Debug -DBUILD_SHARED_LIBS=OFF ..
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the -DASAN=ON ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants