Fixed unsafe string dup behaviour. #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alvin1221 plz fix related unsafe strcmp |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #153 +/- ##
==========================================
+ Coverage 61.42% 61.46% +0.03%
==========================================
Files 99 99
Lines 26480 26484 +4
==========================================
+ Hits 16266 16278 +12
+ Misses 10214 10206 -8
... and 20 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
JaylinYu
approved these changes
Mar 31, 2023
wanghaEMQ
reviewed
Apr 3, 2023
| { | ||
| topic_qos[index].topic.buf = (uint8_t *) nni_strdup(topic_name); | ||
| topic_qos[index].topic.length = (uint32_t) strlen(topic_name); | ||
| topic_qos[index].topic.buf = (uint8_t *) nni_alloc(len * sizeof(uint8_t)); |
There was a problem hiding this comment.
Why not just use function strndup()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.