Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the heapOverflow in logs. #144

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Fix the heapOverflow in logs. #144

merged 1 commit into from
Mar 21, 2023

Conversation

wanghaEMQ
Copy link
Member

Multi-stream feature has passed the test.

MultiStream is supported (passed the test).
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +0.20 🎉

Comparison is base (e6f5a44) 54.46% compared to head (83ea892) 54.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
+ Coverage   54.46%   54.66%   +0.20%     
==========================================
  Files          95       95              
  Lines       25333    25333              
==========================================
+ Hits        13797    13848      +51     
+ Misses      11536    11485      -51     
Impacted Files Coverage Δ
src/mqtt/protocol/mqtt/mqtt_quic.c 0.00% <0.00%> (ø)

... and 13 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@JaylinYu JaylinYu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually we should remove all logging from SDK

@wanghaEMQ
Copy link
Member Author

actually we should remove all logging from SDK

You are right. But maybe after syncing all the codes from nanonng.

@wanghaEMQ wanghaEMQ merged commit 3672e33 into main Mar 21, 2023
@JaylinYu JaylinYu deleted the wangha/sync branch March 21, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants