Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(desktop): upgrade Node.js version to 18 #1876

Merged
merged 6 commits into from
Feb 25, 2025
Merged

chore(desktop): upgrade Node.js version to 18 #1876

merged 6 commits into from
Feb 25, 2025

Conversation

Red-Asuka
Copy link
Member

@Red-Asuka Red-Asuka commented Feb 24, 2025

PR Checklist

If you have any questions, you can refer to the Contributing Guide

What is the current behavior?

The desktop is currently using Node.js v16, which is outdated and difficult to maintain.

What is the new behavior?

  • Upgrade Node.js to v18.

Known Issues:

  • Unable to successfully package the pkg on macOS, issue is still being diagnosed.
  • SQLite3 does not provide precompiled Windows ARM64 packages, requiring cross-compilation and additional testing.

Does this PR introduce a breaking change?

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to review?

Other information

@Red-Asuka Red-Asuka self-assigned this Feb 24, 2025
@Red-Asuka Red-Asuka added dependencies Pull requests that update a dependency file chore Changes in build tools or dependent packages desktop MQTTX Desktop labels Feb 24, 2025
@Red-Asuka Red-Asuka added this to the v1.12.0 milestone Feb 24, 2025
@Red-Asuka Red-Asuka force-pushed the lyd/dev branch 4 times, most recently from 63ed23c to 91a7222 Compare February 24, 2025 14:12
@Red-Asuka Red-Asuka requested a review from ysfscream February 25, 2025 02:04
@Red-Asuka Red-Asuka marked this pull request as ready for review February 25, 2025 02:04
@ysfscream ysfscream merged commit 031c260 into main Feb 25, 2025
4 checks passed
@ysfscream ysfscream deleted the lyd/dev branch February 25, 2025 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes in build tools or dependent packages dependencies Pull requests that update a dependency file desktop MQTTX Desktop
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants