Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(desktop): traffic rate monitor support #1795

Merged
merged 1 commit into from
Nov 1, 2024
Merged

feat(desktop): traffic rate monitor support #1795

merged 1 commit into from
Nov 1, 2024

Conversation

ysfscream
Copy link
Member

@ysfscream ysfscream commented Nov 1, 2024

PR Checklist

If you have any questions, you can refer to the Contributing Guide

What is the new behavior?

image

This pull request includes significant updates to the chart components, traffic monitoring, and utility functions. The changes introduce new features, improve functionality, and enhance code readability. Below are the most important changes:

Chart Components

  • Renamed AreaLine.vue to LineChartExtent.vue and added a new type prop to switch between 'area' and 'line' chart types. Updated the chart rendering logic to handle the new type prop. [1] [2] [3]
  • Added a new NumberCard.vue component to display numerical values with optional icons and labels.

Traffic Monitoring

  • Enhanced TrafficMonitor.vue to include rate calculation and display for received and sent traffic. Added new methods to handle metrics updates and chart initialization. [1] [2] [3]
  • Updated traffic statistics to display both accumulated traffic and rate of traffic in separate charts.

Utility Functions

  • Refactored systemTopic.ts to merge received and sent metrics, calculate traffic rates, and transform traffic messages. Removed unused functions related to system topics.
  • Improved formatter.ts to handle byte formatting more accurately and added handling for values less than one byte.

Miscellaneous

  • Updated viewer.ts to include new translations for traffic rate labels.
  • Adjusted imports in TopicTree.vue to reflect the new file paths for TreeView.vue and TreeNodeInfo.vue.

@ysfscream ysfscream added enhancement New feature or request feature This pr is a feature desktop MQTTX Desktop labels Nov 1, 2024
@ysfscream ysfscream added this to the v1.11.1 milestone Nov 1, 2024
@ysfscream ysfscream requested a review from Red-Asuka November 1, 2024 06:43
@ysfscream ysfscream self-assigned this Nov 1, 2024
@Red-Asuka Red-Asuka merged commit 6575017 into main Nov 1, 2024
2 checks passed
@Red-Asuka Red-Asuka deleted the ysf/desktop branch November 1, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop MQTTX Desktop enhancement New feature or request feature This pr is a feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants