fix(connections): fix can send empty auth info

emqx · Dec 19, 2023 · 371e17a · 371e17a
1 parent b1f0e3f
commit 371e17a
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/utils/mqttUtils.ts b/src/utils/mqttUtils.ts
@@ -83,6 +83,9 @@ const getClientOptions = (record: ConnectionModel): IClientOptions => {
   }
   if (password !== '') {
     options.password = password
+    if (username === undefined || username === '') {
+      options.username = ''
+    }
   }
   // SSL
   if (ssl) {
@@ -148,7 +151,7 @@ export const createClient = (
       topicAliasMaximum: options.properties ? options.properties.topicAliasMaximum : undefined,
     }
     const { password, username, protocolVersion } = tempOptions
-    if (password && username === undefined && protocolVersion !== 5) {
+    if (password && (username === undefined || username === '') && protocolVersion !== 5) {
       return reject(new Error('MQTT 3.1.1 requires a Username if a Password is set'))
     }
     const curConnectClient: MqttClient = mqtt.connect(url, tempOptions)