Tweak how displayName is read in the shallow printer #2336
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: fix #2321
Why: not necessary, just a patch fix.
How: add
displayName
to support better jest-test UXChecklist:
@fffed report a issue abount
enzyme-serializer returns undefined
at issue 2321.Then I try to debug
emotion-js
source code, and found why the serializer return aundefined
!noticed that
emotionType
not always be a string or a normal react component, it can be aforward
component,React.forwardRef
hasdisplayName
but noname
How to fix it ?
Now the jest unit test snapshot be more hunman readable.
Hope
emotion
maintainer can code review thisPR
, thanks ! /cc @mitchellhamilton @Andarist