Fix incorrectly throwing error on valid content values in dev #2279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove invalid regex pattern `calc` * Remove invalid content value `counter` * Several content values can be used simultaneously, except for `normal`, `none` and global values
🦋 Changeset detectedLatest commit: b20b5aa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b20b5aa:
|
Andarist
reviewed
Mar 16, 2021
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Fix incorrectly throwing error on valid content values in dev
Why:
This change allows using multiple valid content values like
content: open-quote counter(chapter_counter);in dev. Per doc https://developer.mozilla.org/en-US/docs/Web/CSS/content, several values can be used simultaneously, except fornormal,noneand global values.How:
contentValuePatternregex for the cases of multiple content valuescalccounterincontentValuesChecklist: