Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "option", "fallback" amp html property to whitelist #2232

Merged
merged 2 commits into from
Jan 30, 2021
Merged

add "option", "fallback" amp html property to whitelist #2232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4082bb7
add "option", "fallback" amp html property to whitelist
ka2jun8 Jan 28, 2021
002e84c
Create wet-apes-report.md
Andarist Jan 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/wet-apes-report.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@emotion/is-prop-valid": minor
---

Added `option` & `fallback` AMP props to the list of valid props.
7 changes: 7 additions & 0 deletions packages/is-prop-valid/src/props.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,9 @@ const props = {
autoSave: true,
// color is for Safari mask-icon link
color: true,
// used in amp html for indicating the fallback behavior
// https://amp.dev/documentation/guides-and-tutorials/develop/style_and_layout/placeholders/
fallback: true,
// https://html.spec.whatwg.org/multipage/interaction.html#inert
inert: true,
// itemProp, itemScope, itemType are for
Expand All @@ -199,7 +202,11 @@ const props = {
itemID: true,
itemRef: true,
// used in amp html for eventing purposes
// https://amp.dev/documentation/guides-and-tutorials/learn/common_attributes/
on: true,
// used in amp html for indicating that the option is selectable
// https://amp.dev/documentation/components/amp-selector/
option: true,
// results show looking glass icon and recent searches on input
// search fields in WebKit/Blink
results: true,
Expand Down