Revert "Moves the loading of Aspace repositories to the controller action (#2168). (#2230)" #2253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bwatson78 what is the reasoning behind this change? |
|
@abelemlih Since we've determined that our code isn't at fault and Lyrasis' API seems to stop accepting our password periodically, your AJAX code is preferred over a controller action so that we can load the page before running into any API tomfoolery. |
|
@abelemlih Per @rotated8, I'll be making another PR to provider a default option that reports the API isn't communicating correctly. |
abelemlih
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c57dfd0.