Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Full-Text Search Indexing button to works' show page. #2189

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Adds Full-Text Search Indexing button to works' show page. #2189

merged 2 commits into from
Aug 10, 2023

Conversation

bwatson78
Copy link
Contributor

@bwatson78 bwatson78 commented Aug 10, 2023 •
edited
Loading

  • app/assets/stylesheets/_work_show_page.scss: forces the two buttons side-by-side.
  • app/assets/stylesheets/curate.scss: imports the new partial into the application's specific css file.
  • app/controllers/full_text_indexing_controller.rb: creates an action that queues CompileFullTextJob.
  • app/views/hyrax/base/_show_actions.html.erb: reworks the buttons to include Full-Text button next to Regenerate Manifest.
  • config/routes.rb: ties the new controller action to a route.
  • spec/*: tests the new code.
  • spec/spec_helper.rb: addresses new annoying behavior affecting local testing.
    Screenshot 2023-08-10 at 10 47 00 AM

@bwatson78 bwatson78 self-assigned this Aug 10, 2023
@bwatson78 bwatson78 marked this pull request as ready for review August 10, 2023 15:54
@bwatson78 bwatson78 requested review from alexBLR and abelemlih August 10, 2023 15:54
@bwatson78 bwatson78 added enhancement New feature or request ruby Pull requests that update Ruby code labels Aug 10, 2023
@bwatson78 bwatson78 linked an issue Aug 10, 2023 that may be closed by this pull request
Implement fulltext indexing and search across works in Curate and Lux #2185
Open
5 tasks
@abelemlih abelemlih merged commit ce551b3 into main Aug 10, 2023
@abelemlih abelemlih deleted the add_full_text_indexing_job_to_ui branch August 10, 2023 16:01
@bwatson78 bwatson78 mentioned this pull request Aug 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abelemlih abelemlih abelemlih approved these changes

@alexBLR alexBLR Awaiting requested review from alexBLR

Assignees

@bwatson78 bwatson78

Labels
enhancement New feature or request ruby Pull requests that update Ruby code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement fulltext indexing and search across works in Curate and Lux
2 participants
@bwatson78 @abelemlih