Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename id_source to id_salt or similar #5020

Closed
emilk opened this issue Aug 28, 2024 · 2 comments
Closed

Rename id_source to id_salt or similar #5020

emilk opened this issue Aug 28, 2024 · 2 comments
Milestone
Next Major Release

Comments

@emilk
Copy link
Owner

emilk commented Aug 28, 2024

A lot of widgets take an id_source which is mixed in with the id of the parent Ui. This is a misleading name - this is not the source of the id, just a salt added to an existing hash. So id_salt would be a better name. Perhaps we can find an even better one?
@emilk emilk added this to the Next Major Release milestone Aug 28, 2024
@rustbasic
Copy link
Contributor

id_salt, id_modifier, id_suffix, id_hash_suffix

id_salt seems easy to use.
id_modifier seems easy to understand.

@bircni bircni mentioned this issue Aug 28, 2024
Merged
1 task
emilk pushed a commit that referenced this issue Sep 2, 2024
@bircni
Rename id_source to id_salt (#5025)
be944f0 
* Closes <#5020 >
* [x] I have followed the instructions in the PR template
@emilk
Copy link
Owner Author

emilk commented Sep 2, 2024

@emilk emilk closed this as completed Sep 2, 2024
hacknus pushed a commit to hacknus/egui that referenced this issue Oct 30, 2024
@bircni @hacknus
Rename id_source to id_salt (emilk#5025)
ea20254 
* Closes <emilk#5020 >
* [x] I have followed the instructions in the PR template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Next Major Release
Development

No branches or pull requests
2 participants
@emilk @rustbasic