Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Finish merging selcomps v2.5 #15

Merged
merged 12 commits into from
Aug 23, 2018
Merged

Conversation

tsalo
Copy link

@tsalo tsalo commented Aug 23, 2018

I think selcomps should work after these changes are merged.

Changes proposed in this pull request:

  • Corrects getelbow import to getelbow_mod
  • Add arguments mmix, manacc, and n_echos to selcomps.
    • We use mmix to get the number of volumes, which was originally used and stored as nt
    • This supports manually defined accepted components with manacc
    • n_echos was required (stored as ne) but wasn't defined
  • Extract relevant fields from seldict rather than unpacking with eval
  • This PR also includes recent commits to master

@emdupre
Copy link
Owner

emdupre commented Aug 23, 2018

❤️ thank you !!

@emdupre emdupre merged commit 7d4ac90 into emdupre:selcomps-2.5 Aug 23, 2018
@tsalo tsalo deleted the selcomps branch August 23, 2018 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants