Skip to content

Commit

Permalink
Only disable request handling for HTTP/S schemes (see issue chromiume…
Browse files Browse the repository at this point in the history
…mbedded#3110)

The `--disable-request-handling-for-testing` command-line flag would previously
disable handling of all schemes, including custom schemes and internal schemes
such as devtools.
  • Loading branch information
magreenblatt committed Oct 5, 2021
1 parent 5b52963 commit 09ee681
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion libcef/browser/net_service/proxy_url_loader_factory.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1313,7 +1313,7 @@ void ProxyURLLoaderFactory::CreateLoaderAndStart(
return;
}

if (DisableRequestHandlingForTesting()) {
if (DisableRequestHandlingForTesting() && request.url.SchemeIsHTTPOrHTTPS()) {
// This is the so-called pass-through, no-op option.
if (target_factory_) {
target_factory_->CreateLoaderAndStart(std::move(receiver), request_id,
Expand Down

0 comments on commit 09ee681

Please sign in to comment.