fix renamed-modules when used with languages that transpile to js #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `rewriteAddonTree` transformation captures any modules that are trying to escape their own package namespace and records their names as our `renamed-modules` in the addon metadata. But if you are using typescript or another preprocessor that changes the file extensions, we currently save the renamed-modules and then transpile, which results in the names in the metadata not matching the actual files. This switches the order so we preprocessor first and then record the renamed-modules.
|
(I need to come back around and add test coverage here.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
rewriteAddonTreetransformation captures any modules that are trying to escape their own package namespace and records their names as ourrenamed-modulesin the addon metadata. But if you are using typescript or another preprocessor that changes the file extensions, we currently save the renamed-modules and then transpile, which results in the names in the metadata not matching the actual files.This switches the order so we preprocessor first and then record the renamed-modules.