Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A POC of how addons could be selectively rebuilt if Broccoli passed change information into the plugin. The goal of this PR is to get overall feedback on the strategy and to confirm this is a viable path forward. I will add tests once we work out the higher level vision of this.
Overall Strategy:
Perf:
Measuring the execution time of the build callback for a brand new app:
With change tracking: ~50ms
Without: ~75ms
I have not tested this in a large app but change tracking should stay relatively constant were as without change tracking will obviously grow with the number of addons.
Limitations:
This conditional checking would only be available for those that are using the version of broccoli were this is enabled. These changes are backwards compatible however there would be performance implications for those not on it.
Open Questions for Reviewers:
#253