Module resolver: virtualize test-support.js #1807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansona
force-pushed
the
virtual-entry-point
branch
7 times, most recently
from
425215f to
0c31ba0
Compare
mansona
force-pushed
the
virtual-entry-point
branch
6 times, most recently
from
44981c2 to
00e95a1
Compare
mansona
force-pushed
the
virtual-entry-point
branch
from
00e95a1 to
f61220a
Compare
BlueCutOfficial
commented
Apr 4, 2024
…neration of test-support.js with the virtual entrypoint
ef4
reviewed
Apr 4, 2024
|
|
||
| function impliedAddonTestSupport(engine: Engine): string[] { | ||
| let result: Array<string> = []; | ||
| for (let addon of sortBy(Array.from(engine.addons.keys()), pkg => { |
There was a problem hiding this comment.
I think we can delete the sortBy. It was only being used by implicit-scripts not implicit-test-scripts, and now that this function only handles implicit-test-scripts this part should never have an effect.
ef4
reviewed
Apr 4, 2024
packages/core/src/module-resolver.ts
Outdated
|
|
||
| if (!pkg?.isV2Ember()) { | ||
| throw new Error(`bug: an import of ${request.specifier} in non-ember package at ${request.fromFile}`); | ||
| } |
There was a problem hiding this comment.
We can remove this check, the check up above for being the first engine is sufficient.
|
Thanks, nice work! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Virtualization of the test-support entry point.
This PR replaces the script tag
src="assets/test-support.js"with the virtual entry pointsrc="@embroider/core/test-support"in theindex.htmlof the rewritten app. The content that was previously written inassets/test-support.jsis now generated by thevirtual-test-support's functions.How to test
virtual-vendorbranch: