Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests? #1

Closed
rwjblue opened this issue Oct 17, 2018 · 2 comments
Closed

Tests? #1

rwjblue opened this issue Oct 17, 2018 · 2 comments

Comments

@rwjblue
Copy link
Collaborator

rwjblue commented Oct 17, 2018

Not sure if I've missed something in the layout, but I'm curious how you've been testing as there don't seem to be tests in the repo at all...
@ef4
Copy link
Contributor

ef4 commented Oct 17, 2018

Yes, there are no automated tests here yet. The reason is that my standard of correctness is whatever the hell existing addons and apps do, and I'm still in the process of characterizing that. I deliberately don't want to be one of those projects that has a lovely test suite but then an extremely painful integration into real apps. So I have overweighted on testing in real apps.

We will absolutely want to crystalize those semantics in the form of a test suite, and in principle it would be great to do little by little as we go, but deciding what "correct" looks like has still been undergoing pretty big churn as I find more "fun" parts of the existing ecosystem.

Right now this repo is an impenetrable wall of code with literally nothing that is easy to run. That is why I dragged my feet on sharing it -- I know it's not usable by anybody else yet. But people were clamoring to see it.

@ef4
Copy link
Contributor

ef4 commented Apr 13, 2019

There are now many tests.

@ef4 ef4 closed this as completed Apr 13, 2019
ef4 pushed a commit that referenced this issue Dec 12, 2019
@kandhavivekraj
Merge pull request #1 from kandhavivekraj/fix_css_reorder
3fdc42a 
fix: css reorder issue
ef4 pushed a commit that referenced this issue Apr 23, 2021
@charlespierce
Merge pull request #1 from embroider-build/peer-dependencies2
360579e 
move peerDep check into activeAddonChildren
mansona pushed a commit that referenced this issue Jun 7, 2023
@22a
Add test scenario for tests: true storeConfigInMeta: false config (…
2949e9b 
…#1)

* add skeleton scenario with TODO comments

* implementing Ed's higher-order test recommendation

* fix locationType for tests
NullVoxPopuli added a commit that referenced this issue Oct 2, 2024
@NullVoxPopuli
Rename @embroider/core/entrypoint to @embroider/virtual/compat-module…
ac242d3 
…s, Resolving #2025

Approach #1: Create package, @embroider/virtual
NullVoxPopuli added a commit that referenced this issue Oct 2, 2024
@NullVoxPopuli
Rename @embroider/core/entrypoint to @embroider/virtual/compat-module…
9512c38 
…s, Resolving #2025

Approach #1: Create package, @embroider/virtual
NullVoxPopuli added a commit that referenced this issue Oct 2, 2024
@NullVoxPopuli
Rename @embroider/core/entrypoint to @embroider/virtual/compat-module…
c9291af 
…s, Resolving #2025

Approach #1: Create package, @embroider/virtual
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rwjblue @ef4